Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - SAML IdP Attribute Definitions and Release #4410

Closed
wants to merge 16 commits into from

Conversation

tsschmidt
Copy link
Contributor

@tsschmidt tsschmidt commented Nov 6, 2019

This PR allows defining SAML attributes for release whose values are populated from existing attribute repositories configured in CAS. Attribute definitions are loaded from a configured JSON source that is dynamically reloaded when changes are detected.

Attribute definitions have the following properties:

  • Map Key - Key used to reference the definition.
  • 'attribute' - Attribute key in configured repositories to as a value for this definition. Defaults to map key if not present,
  • 'name' - Value used in the SAML response name attribute. Defaults to map key if not present.
  • 'friendlyName' - Value used in the SAML Response friendlyName attribute. Defaults to map key if not present.
  • 'scoped' - If set to to true the SAML IdP scope will be appended the value of the attribute
  • 'template' - A Message formatted string that will inject the attribute and release the combined value.
  • 'script' - File location of a groovy script to execute to determine the value to release.

These defined attributes can then be released by using SamlIdpRegisteredServiceAttributeReleasePolicy and setting the map keys in the 'allowedAttributes' that should be part of the SAML Response.

@mmoayyed mmoayyed changed the title SAML IdP Attribute Definitions and Release WIP - SAML IdP Attribute Definitions and Release Nov 14, 2019
@stale
Copy link

stale bot commented Nov 21, 2019

This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added Pending and removed Pending labels Nov 21, 2019
@stale
Copy link

stale bot commented Nov 29, 2019

This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added Pending and removed Pending labels Nov 29, 2019
@mmoayyed mmoayyed removed this from the 6.2.0-RC1 milestone Dec 1, 2019
@stale
Copy link

stale bot commented Jan 31, 2020

This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mmoayyed
Copy link
Member

mmoayyed commented Feb 3, 2020

I have begun refactoring this pull request to bring it up to speed based on earlier discussions on dev. Hoping to finalize before the GA release, if not earlier.

@stale
Copy link

stale bot commented Feb 10, 2020

This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mmoayyed
Copy link
Member

Polished and pushed.

@mmoayyed mmoayyed closed this Feb 10, 2020
@mmoayyed mmoayyed deleted the saml-attributes branch February 10, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants