Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the authentication delegation to a CAS server #4548

Closed
wants to merge 1 commit into from
Closed

Fix the authentication delegation to a CAS server #4548

wants to merge 1 commit into from

Conversation

leleuj
Copy link
Contributor

@leleuj leleuj commented Dec 16, 2019

The authentication delegation to a CAS server has a big issue. It seems to work, but it doesn't. You generally see that under a certain workload, but it can be reproduced fairly easily.
The TST is saved into the customParams of the configuration of the CasClient which is a problem because it's a singleton so the TST used at the time of the ticket validation (CasAuthenticator) can be the one of another authentication delegation.
This PR fixes the issue by using the session instead.

It can be tested easily with this project: https://github.com/casinthecloud/cas-pac4j-oauth-demo (master branch). It's the version 6.2.0-RC1, but all CAS versions have the same code and issue.

  • Call the login page (http://localhost:8080/cas/login) and start the authentication delegation to a CAS server by clicking on the "CAS" button.
  • Do the same in another browser and finish the login process: it works
  • Return to the first browser and finish the login process: it doesn't work.

@apereocas-bot
Copy link
Contributor

apereocas-bot commented Dec 16, 2019

Thank you very much for submitting this pull request! Please note that this patch is targeted at a CAS branch that is no longer maintained and as such cannot be accepted or merged. For additional details, please review https://apereo.github.io/cas/developer/Maintenance-Policy.html

If you are seeking assistance or have a question about your CAS deployment, please visit https://apereo.github.io/cas/Support.html for support options.

CAS - Enterprise Single Sign-On for the Web
CAS - Enterprise Single Sign-On for the Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants