New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/extended themes #5133
Merged
Merged
Feature/extended themes #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoayyed
requested changes
May 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A few comments on the structure of the theme.
support/cas-server-support-themes-collection/src/main/resources/static/themes/twbs/js/cas.js
Outdated
Show resolved
Hide resolved
...as-server-support-themes-collection/src/main/resources/templates/twbs/fragments/scripts.html
Outdated
Show resolved
Hide resolved
...as-server-support-themes-collection/src/main/resources/templates/twbs/fragments/scripts.html
Outdated
Show resolved
Hide resolved
...as-server-support-themes-collection/src/main/resources/templates/twbs/fragments/scripts.html
Outdated
Show resolved
Hide resolved
support/cas-server-support-themes-collection/src/main/resources/templates/twbs/layout.html
Outdated
Show resolved
Hide resolved
mmoayyed
requested changes
May 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2nd round of reviews. Thanks for the updates so far. Comments follow.
ci/tests/puppeteer/scenarios/themes-collection-twbs-caps/script.js
Outdated
Show resolved
Hide resolved
ci/tests/puppeteer/scenarios/themes-collection-twbs-login/script.js
Outdated
Show resolved
Hide resolved
support/cas-server-support-themes-collection/src/main/resources/static/themes/twbs/js/cas.js
Outdated
Show resolved
Hide resolved
support/cas-server-support-themes-collection/src/main/resources/templates/twbs/layout.html
Outdated
Show resolved
Hide resolved
support/cas-server-support-themes-collection/src/main/resources/twbs.properties
Outdated
Show resolved
Hide resolved
support/cas-server-support-themes-collection/src/main/resources/twbs.properties
Outdated
Show resolved
Hide resolved
support/cas-server-support-themes-collection/src/main/resources/twbs.properties
Outdated
Show resolved
Hide resolved
support/cas-server-support-themes-collection/src/main/resources/templates/twbs/layout.html
Outdated
Show resolved
Hide resolved
ci/tests/puppeteer/scenarios/themes-collection-twbs-login/script.js
Outdated
Show resolved
Hide resolved
...t/cas-server-support-themes-collection/src/main/resources/static/themes/twbs/js/bootstrap.js
Outdated
Show resolved
Hide resolved
support/cas-server-support-thymeleaf/src/main/resources/static/js/material.js
Outdated
Show resolved
Hide resolved
support/cas-server-support-thymeleaf/src/main/resources/static/js/passwordMeter.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for a Bootstrap based theme by adding the classes back to the default templates. The theme itself only requires a custom layout.html and scripts.html to swap the libraries themselves, plus the .properties file, and accompanying CSS/JS.
This Boostrap theme is completely bare Bootstrap and does not include any branding for CAS, etc. It is intended for adopters to override and make upgrading from previous versions a simpler process.