Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/extended themes #5133

Merged
merged 45 commits into from Oct 25, 2021
Merged

Conversation

rmathis
Copy link
Contributor

@rmathis rmathis commented Apr 22, 2021

This change adds support for a Bootstrap based theme by adding the classes back to the default templates. The theme itself only requires a custom layout.html and scripts.html to swap the libraries themselves, plus the .properties file, and accompanying CSS/JS.

This Boostrap theme is completely bare Bootstrap and does not include any branding for CAS, etc. It is intended for adopters to override and make upgrading from previous versions a simpler process.

@mmoayyed mmoayyed modified the milestones: 6.4.0-RC4, 6.4.0-RC5 May 9, 2021
Copy link
Member

@mmoayyed mmoayyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few comments on the structure of the theme.

@rmathis rmathis requested a review from mmoayyed May 25, 2021 14:12
Copy link
Member

@mmoayyed mmoayyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd round of reviews. Thanks for the updates so far. Comments follow.

@mmoayyed mmoayyed modified the milestones: 6.4.0-RC5, 6.5.0-RC1 Jun 12, 2021
@mmoayyed mmoayyed marked this pull request as draft June 17, 2021 04:40
@rmathis rmathis marked this pull request as ready for review July 30, 2021 20:32
@rmathis rmathis marked this pull request as ready for review August 11, 2021 21:40
@mmoayyed mmoayyed modified the milestones: 6.5.0-RC1, 6.5.0-RC2 Oct 10, 2021
@mmoayyed mmoayyed merged commit cf13be0 into apereo:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants