Fix ConcurrentModificationException on Redis / PT

[leleuj]

master: https://github.com/apereo/cas/pull/6068

[apereocas-bot]

This pull request is approved and it will be merged shortly. Thank you very much! 🎉🎉

[mmoayyed]

Please note that the change here breaks both ignite and memcached ticket registries. Apache ignite now requires special and additional add-opens parameters to get access to the concurrent hash map, and memcached breaks because it cannot serialize the new map type.

[mmoayyed]

CasKryoTranscoderTests > verifyEncodeDecodeTGTImpl() FAILED
    com.esotericsoftware.kryo.KryoException: com.esotericsoftware.kryo.KryoException: java.lang.IllegalArgumentException: Class is not registered: java.util.concurrent.ConcurrentHashMap
    Note: To register this class use: kryo.register(java.util.concurrent.ConcurrentHashMap.class);
    Serialization trace:
    services (org.apereo.cas.ticket.TicketGrantingTicketImpl)
        at org.apereo.cas.memcached.kryo.CasKryoTranscoder.encode(CasKryoTranscoder.java:57)
        at org.apereo.cas.memcached.kryo.CasKryoTranscoderTests.verifyEncodeDecodeTGTImpl(CasKryoTranscoderTests.java:176)

        Caused by:
        com.esotericsoftware.kryo.KryoException: java.lang.IllegalArgumentException: Class is not registered: java.util.concurrent.ConcurrentHashMap
        Note: To register this class use: kryo.register(java.util.concurrent.ConcurrentHashMap.class);
        Serialization trace:
        services (org.apereo.cas.ticket.TicketGrantingTicketImpl)
            at com.esotericsoftware.kryo.serializers.ReflectField.write(ReflectField.java:102)
            at com.esotericsoftware.kryo.serializers.FieldSerializer.write(FieldSerializer.java:109)
            at com.esotericsoftware.kryo.Kryo.writeClassAndObject(Kryo.java:711)
            at org.apereo.cas.memcached.kryo.CasKryoTranscoder.encode(CasKryoTranscoder.java:52)
            ... 1 more

            Caused by:
            java.lang.IllegalArgumentException: Class is not registered: java.util.concurrent.ConcurrentHashMap
            Note: To register this class use: kryo.register(java.util.concurrent.ConcurrentHashMap.class);
                at com.esotericsoftware.kryo.Kryo.getRegistration(Kryo.java:579)
                at com.esotericsoftware.kryo.util.DefaultClassResolver.writeClass(DefaultClassResolver.java:112)
                at com.esotericsoftware.kryo.Kryo.writeClass(Kryo.java:613)
                at com.esotericsoftware.kryo.serializers.ReflectField.write(ReflectField.java:68)
                ... 4 more

[leleuj]

I was confident about the PR as the bot approved and merged it. I will check and fix that.

[leleuj]

I just opened: #6072 to fix the build...

[leleuj]

Despite adding the --add-opens java.base/java.util=ALL-UNNAMED at the JVM level: https://github.com/apereo/cas/actions/runs/9674994424/job/26691747771#step:7:15, the Ignite tests still fail.

I don't to see what I'm missing...

GitHub

Fix build after #6069 · apereo/cas@ceab4b1

Apereo CAS - Identity & Single Sign On for all earthlings and beyond. - Fix build after #6069 · ceab4b1