Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV/TSV source for lang names #115

Closed
sushain97 opened this issue Sep 6, 2018 · 4 comments
Closed

CSV/TSV source for lang names #115

sushain97 opened this issue Sep 6, 2018 · 4 comments

Comments

@sushain97
Copy link
Member

Convert at build time

@jonorthwash
Copy link
Member

I don't mind writing sql?

@sushain97
Copy link
Member Author

sushain97 commented Sep 6, 2018 via email

@sushain97
Copy link
Member Author

sushain97 commented Sep 6, 2018

Pros:

  • Better rendering/appearance on GitHub/editor especially with TSV (subjective, I guess)
  • Easier to edit, especially for non-SQL folks
  • Easy to force sorting so that dupes are easy to see
  • Smaller file size

Cons:

  • Somewhat more complex build

I think pros outweigh cons in this case. Thoughts?

@jonorthwash
Copy link
Member

jonorthwash commented Dec 4, 2018

We also probably need to merge turkic.sql and manual.sql.

Another Pro:

  • less confusing when input data is all tsv and output data is all sql.

We should keep a dichotomy between scraped and our modifications (whether we call it manual or something else).

Note that writing sql isn't that big a deal. People who don't know it should still be fine, and if they really are uncomfortable with it, it's never too late to learn :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants