suggestion feature #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can not send POST request)
Add suggestions route and wiki api functionality
|
The build is failing! :( Can you look into it, @Kira-D? |
servlet.py
Outdated
| if recap == bypassToken: | ||
| logging.info('Adding data to wiki with bypass token') | ||
| else: | ||
|
|
|
@unhammer can you please help with an integration error. It seems something wrong with tornado library for python 3.2 |
|
merge (or cherry-pick) a4e8966 |
so use tornado 4.3 when python 3.2, otherwise newest tornado
|
Thanks! Btw, I can see your fix and my code committed in master in one commit. |
|
Btw, I can see your fix and my code committed in master in one commit.
Is it ok?
if I understand correctly, yeah – git prefers it being the same commit
|
|
And from the point of view of GSoC, I think it doesn't really matter—in On 24 August 2016 at 13:46, Kevin Brubeck Unhammer <notifications@github.com
|
|
Anyone still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't forget to register production site at https://www.google.com/recaptcha/admin and make a wiki user page for this feature