Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 55 suggestions 2 #393

Closed

Conversation

thehanimo
Copy link

Resolve merge conflicts and fix minor UI issues with the suggestions modal.

sushain97 and others added 26 commits March 29, 2019 18:22
* Add arabic strings

* Fix build
Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.2.
- [Release notes](https://github.com/mysticatea/eslint-utils/releases)
- [Commits](mysticatea/eslint-utils@v1.3.1...v1.4.2)

Signed-off-by: dependabot[bot] <support@github.com>
* Fixed dropdowns in RTL mode

* Comply with es-lint

* Comply with flow

* tweak to attempt triggering a docker build

* one more attempt to trigger this build
* More sensible default language pair

more sensible default language pair when apertium.org is loaded

* Update index.html.in

* Update translator.js

* Update translator.js Fixes

* Update translator.js

* Fixes, Changed to Loop, default set to locale

* Fixed Error on loading locale pair.

* Update translator.js

removed unwanted space!

* Updated to support IE

* Fixing Unavailable User Prefered Language

* Update translator.js

* Fix

* Shortening the code. :)

* Fixed on Feedback of Sushain

* Fixes!

* Fixes

* Further Fixes

* Updated

* eng to first available pair

* Update translator.js

* Fixed and Updated :0

* Error Fixes

* error fix

* Update translator.js

* Update translator.js

* Changed Each to for

* Update translator.js

* Update translator.js

* test

* test

* test 2

* Update translator.js

* Update translator.js

* Update translator.js

* Update translator.js

* Update translator.js

* Last

* Update translator.js

* Update translator.js

* Update translator.js

* Update translator.js

* Update translator.js

* Apply suggestions from code review

Co-Authored-By: Sushain Cherivirala <sushain@skc.name>

* Applied Changes

* Update translator.js

* Update translator.js

* Update translator.js

* Circleci

* Last Cannot Fix Circleci variable error

* Applied requested changes

* Update translator.js

* Update translator.js

* Update localization.js

* Update translator.js

* Update translator.js

* Fixes

* Fix combining error.

* Updated for IE new versions

* tweaks

* proper conversion

* Updated with fixes

* Update translator.js

* Update translator.js

* Eslint fixes

* Flow fix

* tweaks

* oops

* Eslint Fixes

* Fixes

* Fixing Errors for IE and first visit

* Eslint Fixes.

* Revert "Eslint Fixes."

This reverts commit 8dab62e.

* Revert "Fixing Errors for IE and first visit"

This reverts commit 2918cb5.

* fixes on first visit and IE

* Eslint fixes

* Update translator.js

* Update translator.js

* Eslint Fixes.

* Tweak. :)

* cleanup

* Update translator.js

Co-authored-by: Sushain Cherivirala <sushain@skc.name>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.11...4.17.14)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: Sushain Cherivirala <sushain@skc.name>
* Add files via upload

* Update translator.js

* Update

* Fix Circeci Errors

* Revert "Fix Circeci Errors"

This reverts commit 4b55a2f.

* Revert "Update"

This reverts commit de07132.

* Revert "Update translator.js"

This reverts commit 2148fb7.

* Revert "Add files via upload"

This reverts commit ba0192a.

* Upgrade to Bootstrap 4

* Update bootstrap.css

* Fixed Margin and Dropdown open Issues

* Eslint fixes

* RTL Text area alignment fix

* Removing Unnecessary Styling

* Fixed Button Group Alignment.

* Revert "Fixed Button Group Alignment."

This reverts commit 96d30d6.

* Revert "Revert "Fixed Button Group Alignment.""

This reverts commit e299402.

* Revert "Revert "Revert "Fixed Button Group Alignment."""

This reverts commit b45530f.

* Revert "Revert "Revert "Revert "Fixed Button Group Alignment.""""

This reverts commit 7c42308.

* Revert "Revert "Revert "Revert "Revert "Fixed Button Group Alignment."""""

This reverts commit cee4158.

* Revert "Revert "Revert "Revert "Revert "Revert "Fixed Button Group Alignment.""""""

This reverts commit ef75a0d.

* Fixed RTL Alignment bug; Removed Extra

* Removed Bootstrap RTL CSS

* Fixed Mobile Navbar Bug

* Mobile Btn alignment fix

* Revert "Mobile Btn alignment fix"

This reverts commit df56db1.

* Fixes Bug on Navbar Toggler

* sass lint fixes

* Updated BS4 Version 4.4.1

* Fixed navbar alignment bug during resize

* Heading Hidden Bug Fix

* sasslint Fix

* Test failure fix

* DropBtn, Margin and other opt fixes

* otherTransOpt RTL Fix.

* Sass Lint fix

* Fixes, Refactoring CSS.

* RTL Button group alignment fix

* Update navbar.css

* sasslint fix

* Fixes and Refactoring

* Revert "Fixes and Refactoring"

This reverts commit 533aa2b.

* Revert "Revert "Fixes and Refactoring""

This reverts commit badd6b5.

* Minor Tweak.

* Update assets/css/general.css

Co-Authored-By: Sushain Cherivirala <sushain@skc.name>

* Add Bootstrap 4 utility Classes

* RTL Btn grp fix

* Btn border fix, factoring

* Test fix

* Revert "Test fix"

This reverts commit 5690b45.

* Revert "Btn border fix, factoring"

This reverts commit 6732e77.

* Revert "RTL Btn grp fix"

This reverts commit fc95390.

* Revert "Add Bootstrap 4 utility Classes"

This reverts commit 6a30631.

* Revert "Revert "Add Bootstrap 4 utility Classes""

This reverts commit bd1f513.

* Revert "Revert "RTL Btn grp fix""

This reverts commit cdefe6b.

* Revert "Revert "Btn border fix, factoring""

This reverts commit 7b9ef28.

* Revert "Revert "Test fix""

This reverts commit 830de00.

* Fixed TranslateWeb Bugs

* helpMessage Alignment Fix

* RTL helpMessage and btn alignment Fixes

* Fixed clearButton bug

* Bootstrap Input Shadow color change.

* Furthermore addition of BS4 Utility Classes.

* sass lint Fix

* Update html/index.html.in

Co-Authored-By: Sushain Cherivirala <sushain@skc.name>

* Minor Tweaks

* Transwp Width fix, CDN fix, navbar fix

* Integrity SHA Update.

* 4 modes Navbar fix.

Co-authored-by: Sushain Cherivirala <sushain@skc.name>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.14...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.7)

Signed-off-by: dependabot[bot] <support@github.com>
@TinoDidriksen
Copy link
Member

That changeset and history looks wrong. There are changes unrelated to the actual PR. Please rebase the changes onto current master instead of merging.

@thehanimo
Copy link
Author

Opening a new PR #395

@thehanimo thehanimo closed this Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet