-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 55 suggestions 3 #395
Open
thehanimo
wants to merge
15
commits into
apertium:master
Choose a base branch
from
thehanimo:issue-55-suggestions-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+475
−90
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
766f974
Add suggestions based on #252
thehanimo 9a4f315
Update flow config
thehanimo 3426ec2
Lint code
thehanimo 8a36a2e
Add Suggest_Button fallback
thehanimo 0a9f663
Fix tooltip dispose method
thehanimo 22a4ed0
Reset recaptcha on locale change
thehanimo 4f770ef
Lint code
thehanimo 949637e
Run make in assets/strings
thehanimo af88a7c
Fix typo in variable name
thehanimo 69a972f
Merge branch 'master' into issue-55-suggestions-3
thehanimo 182c5b4
Update localization.js
thehanimo 367ba59
Lint code
thehanimo ce16b2c
Add comments
thehanimo 3471649
Update Suggest_Placeholder
thehanimo 01bdecf
Update dynamicLocalizations
thehanimo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these lists need to be updated manually? If so, where from, and how often?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localizeRecaptchaLanguages
is the list of languages reCAPTCHA supports.localizeRecaptchaAlternativeLanguages
provides a fallback language in case the locale (current website language) is not supported by reCAPTCHA.We would need to update either/both when we support new locales or when reCAPTCHA supports more/less languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you put a comment to that effect here?