New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #477 (Build should not rely on git) #481
fixes #477 (Build should not rely on git) #481
Conversation
@sushain97 could you please review my changes? Your feedback would be highly appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable - some questions below.
@@ -4,7 +4,7 @@ | |||
"author": "Sushain Cherivirala <sushain@skc.name>", | |||
"license": "GPL-3.0-or-later", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the version
field above to actually match the latest released GH version if we're going to use it as the canonical source?
package.json
Outdated
@@ -4,7 +4,7 @@ | |||
"author": "Sushain Cherivirala <sushain@skc.name>", | |||
"license": "GPL-3.0-or-later", | |||
"scripts": { | |||
"build": "ts-node build.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do environment variables need to be manually passed through? As far as I'm aware, yarn doesn't modify them from the caller.
Pull Request Test Coverage Report for Build 7208461184
💛 - Coveralls |
@sushain97 sorry for late reply college work has been busy, Sure, I'll update the version in package.json field to actually match the latest released git hub version but i got a doubt , Since we're moving away from direct reliance on Git ,will manual updates to package.json be required for every release? |
Yes. That is the point. It's about what the source of truth is, and I hold that it should be the code - GitHub is merely storage, and must not be an integral part of the project. |
Yes, this is fine. Ideally, we set up a GH workflow to create a tag and it'll fail when the tag already exists and succeed when a commit is pushed to |
I don't disagree with this but I'd argue GitHub isn't relevant here. The tags are a Git construct which is arguably part of the source of truth. The point that a build shouldn't require |
Hey @sushain97 , @TinoDidriksen , I've made some changes to the code. Can you take a look and let me know if everything's good now? Thanks! |
@satti-hari-krishna-reddy CI is failing. |
@sushain97 , I've got the Prettier error fixed, so the CI should be good to go now! |
fixes #477
Description :
This pull request addresses the issue where the build process was relying on Git for version information. The problem arose when the build process did not have Git available.
Changes Made :
-In package.json, updated the
version
field to the latest released GitHub version-In build.ts, modified the code to use the version specified in package.json.