-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve README
files
#52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments. Looks like there are some good improvements. You'll have to make
to fix the build. Also, I think there is at least one other README you missed.
@sushain97 For some reason the build continues to fail, even though I ran |
I can definitely run I'm not sure that using the fenced code blocks is the right approach. See below.
fenced $ ./configure
$ make
# make install fenced $ ./configure
$ make
# make install
fenced $ echo "TODO test sentence 1" | apertium {{languageCode1}}-{{languageCode2}}
TODO test translated sentence 1 fenced $ echo "TODO test sentence 1" | apertium {{languageCode1}}-{{languageCode2}}
TODO test translated sentence 1 |
@sushain97 I think I'll just remove the language hint whenever we have a command's output in the code block (since plain text that isn't a command always gets highlighted in a weird way). |
Well, I believe using |
@sushain97 When I switched from If that looks good to you, let me know and I'll add the |
That is exactly what I tried above... It looks fine for these. |
Also, unfortunately your changes renamed all the files. That needs to be undone :\ You should be editing |
Are you sure? I couldn't find any symlinks in any of the folders. |
Yes, I'm sure. I wrote the code that creates them myself: 0e3f199 |
👍🏻 I didn't think to look at |
@sushain97 Ping 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the IRC links are broken? See https://github.com/sushain97/test-eng#help-and-support
The link works for me. |
GitHub doesn't render links with the IRC protocol: [irc://irc.freenode.net/#apertium](irc://irc.freenode.net/#apertium) is rendered as: irc://irc.freenode.net/#apertium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor requests
Because of 1d2a2d3, Travis fails for some reason. Maybe we need to run |
Yeah, almost all changes to this repo require a |
@sushain97 It would be great if you could run |
Thanks for your work on this, @itaisteinherz ! |
Just some meta tweaks to improve readability. I've also opened apertium/apertium-mlt-heb#1 to apply some of these changes onto
apertium-mlt-heb
.