reparse individual non-parsed words after full sentence #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok so it breaks tests :) Is it an actual failure? a tag changed from pl to sg |
mr-martian
reviewed
Aug 28, 2023
|
In the first test that fails, there are 2 rules and they both change the same variable, and I think something might be going wrong with the ordering of those operations. |
|
OK so it seems all the tests run in |
mitigates #80 We splice in the outputQueueReparsed instead of just replacing in case the output rule changes the number of LU's output.
|
Think I figured it out (didn't notice that checkForReduce changed currentBranch), tests pass now. @mr-martian does it seem OK to merge? |
mr-martian
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as noted in #80 (comment) this tries to do a reparse of single, unparsed words after full parse.
It seems to fix things in corpus runs.
Could it break anything @mr-martian ?