Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use just xmllint instead of $XMLLINT in Makefile.am / generated scripts #28

Closed
unhammer opened this issue Oct 16, 2018 · 2 comments · Fixed by #100
Closed

use just xmllint instead of $XMLLINT in Makefile.am / generated scripts #28

unhammer opened this issue Oct 16, 2018 · 2 comments · Fixed by #100
Labels
good first issue Good for newcomers

Comments

@unhammer
Copy link
Member

Scripts like apertium-validate-dictionary refer to the xmllint that configure finds at the time you ran it, e.g. /opt/local/bin/xmllint. That makes the script not work if you copy it to other computers or install xmllint to a different path. Let it just use xmllint with no path.

(similarly for bash – some systems might use sh there, which is even worse, since sh on some systems is definitely not bash-compatible)
@unhammer unhammer added the good first issue Good for newcomers label Oct 16, 2018
@b-thebest
Copy link

Can I work on this issue?

@TinoDidriksen
Copy link
Member

@b-thebest, yes, and you don't have to ask. Just submit a PR that fixes the issue.

@TinoDidriksen TinoDidriksen mentioned this issue Aug 24, 2020
Merged
TinoDidriksen added a commit that referenced this issue Aug 24, 2020
@TinoDidriksen
Word-bound blanks & Transfuse & Other fixes (#100)
7c9a28b 
Many changes, including the word-bound blank helpers needed for @khannatanmai's GSoC work.

* Removed submodule apertium-get (fixes #4, fixes #16, fixes #36, see apertium/packaging#15)
* Require C++14 (C++1y)
* Changed generic variables and unified where version is defined
* Corrected use of pkg-config
* Use `/usr/bin/env bash` instead of baking in bash path
* Use xmllint from PATH (fixes #28)
* Use xsltproc from PATH
* Added 3 new tools:
  * apertium-wblank-attach: Helper to turn wblank-spans into actual per-word word-bound blanks
  * apertium-wblank-detach: Helper to turn per-word word-bound blanks into wblank-spans
  * apertium-wblank-mode: Converts modes to new-style transfer, inserts wblank helpers, and optionally adds -z to all programs
* The apertium helper script:
  * Will now use [Transfuse](https://github.com/TinoDidriksen/Transfuse) for formats ODT, DOCX, PPTX, and HTML, if Transfuse is in PATH (fixes #69)
  * Always uses apertium-wblank-mode around modes, because wblanks are not specific to Transfuse
    * This also always converts old-style transfer to new-style transfer (see apertium/apertium-eo-ca#2, see apertium/apertium-epo-fra#1)
  * Added `-f odp` as alias for `odt`
  * New envvar `APERTIUM_DATADIR` as alternative to -d
  * New arg -z to enable null-flush mode
  * Require UTF-8 earlier
  * Other cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Word-bound blanks & Transfuse & Other fixes apertium/apertium
3 participants
@unhammer @TinoDidriksen @b-thebest