Some GitHub actions spam channels

[shardulc]

Some actions on GitHub cause begiak to flood the pertinent channels with messages, like opening a review on a pull request:

22:24 < begiak> apertium-apy: sushain97 * review comment created on pull request #43: Looking at this again, perhaps we can combine pairs and chains. Pairs acts normally if there's no "src" and lists the possible destination languages (in the same format) if it does. Thoughts? Just want to have as simple of an API as possible :) https://github.com/goavki/apertium-apy/pull/43#discussion_r94904572
22:24 < begiak> apertium-apy: sushain97 * review comment created on pull request #43: Can you add a comment for each one that explains the semantics of the data structure? i.e. what are the keys and values. https://github.com/goavki/apertium-apy/pull/43#discussion_r94903868
22:25 < sushain> sigh
22:25 < begiak> apertium-apy: sushain97 * review comment created on pull request #43: can you make it clear here whether high weight will lead to this edge being picked or low weight? (in the comment) https://github.com/goavki/apertium-apy/pull/43#discussion_r94904270
22:25 < begiak> apertium-apy: sushain97 * review comment created on pull request #43: Clearly, we need an `in=`. https://github.com/goavki/apertium-apy/pull/43#discussion_r94904757
22:25 < begiak> apertium-apy: sushain97 * review comment created on pull request #43: http://stackoverflow.com/questions/4613000/what-is-the-cls-variable-used-in-python-classes Nice, learned something today! https://github.com/goavki/apertium-apy/pull/43#discussion_r94903997
22:25 < begiak> apertium-apy: sushain97 * review comment created on pull request #43: Is "src" what the other endpoints use or is there a more standard term we've been using? https://github.com/goavki/apertium-apy/pull/43#discussion_r94904352

Or synchronizing a pull request:

[00:52:00] <begiak> apertium-html-tools: sushain97 * pull request #69 "Website translation" synchronize  https://github.com/goavki/apertium-html-tools/pull/69
[00:52:03] <begiak> apertium-html-tools: sushain97 * 00768c4: : assets/js/translator.js, index.html.in: Added User interface for website translation. https://github.com/goavki/apertium-html-tools/commit/00768c
[00:52:06] <begiak> apertium-html-tools: sushain97 * 62353d4: : assets/css/style.css, assets/js/translator.js and 2 other files: Add automatic URL recognition and wire up with APY https://github.com/goavki/apertium-html-tools/commit/62353d
[00:52:09] <begiak> apertium-html-tools: sushain97 * 5ef2418: : assets/js/translator.js, index.html.in: Some UI fixes and send Analytics event https://github.com/goavki/apertium-html-tools/commit/5ef241
[00:52:11] <begiak> apertium-html-tools: sushain97 * 09c1773: assets/js/translator.js: UI fix - sync textarea sizes https://github.com/goavki/apertium-html-tools/commit/09c177
[00:52:14] <begiak> apertium-html-tools: sushain97 * 355ad05: : assets/strings/eng.json, index.html.in: Legend modifications https://github.com/goavki/apertium-html-tools/commit/355ad0
[00:52:17] <begiak> apertium-html-tools: sushain97 * d2c5420: assets/js/: .eslintrc.json, persistence.js and 2 other files: Add persistence for website translation https://github.com/goavki/apertium-html-tools/commit/d2c542
[00:52:19] <begiak> apertium-html-tools: sushain97 * 56b66d3: assets/js/persistence.js: hound https://github.com/goavki/apertium-html-tools/commit/56b66d

Or merging a pull request:

[20:17:21] <begiak> apertium-html-tools: unhammer * 77dc50d: assets/js/persistence.js: The Hound prefers single quotes https://github.com/goavki/apertium-html-tools/commit/77dc50
[20:17:25] <begiak> apertium-html-tools: unhammer * b699a71: assets/js/: persistence.js, translator.js: doh, curSrc/DstLang fallback was already implemented ␍ but pick from pairs, so we don't have to trust srcLangs/dstLangs to be always aligned https://github.com/goavki/apertium-html-tools/commit/b699a7
[20:17:30] <begiak> apertium-html-tools: unhammer * a4b1593: assets/js/: persistence.js, translator.js: doh, curSrc/DstLang fallback was already implemented ␍ but pick from pairs, so we don't have to trust srcLangs/dstLangs to be always aligned https://github.com/goavki/apertium-html-tools/commit/a4b159
[20:17:32] <begiak> apertium-html-tools: unhammer * bbe17a0: assets/js/translator.js: global constant for number of translation list buttons https://github.com/goavki/apertium-html-tools/commit/bbe17a
[20:17:35] <begiak> apertium-html-tools: unhammer * a3ec64b: assets/js/: persistence.js, translator.js: Merge branch 'master' into websiteTranslationGiellatekno https://github.com/goavki/apertium-html-tools/commit/a3ec64

There may be more cases where this happens. Note that these are all wrapped text here, but not on IRC: this is obviously annoying behavior. The fix will most likely require begiak collecting webhook data and not posting it as as soon as it arrives, checking whether it is part of a larger 'series' like a PR review, sync, or merge.

@jonorthwash @sushain97 @wei2912 Anything else that is part of this behavior?

[unhammer]

It also posts edits of comments etc.

[shardulc]

@unhammer That was supposed to post the edited content of the comments, but it looks like the webhook doesn't send that information so it is better if removed.

[wei2912]

I'm not sure if there's other similar behaviour. A good approach would be to bundle similar webhook data received in a time period, say one minute.

[jonorthwash]

Another solution would be to set a variable with a timestamp when one of those particular types of hooks is received, and if the subsequent types of hooks are received within a given time period afterwards (say, one minute, but could be fiddled with), to just skip outputting them.