Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.awikstats module missing commas #485

Closed
ApertiumBot opened this issue May 16, 2019 · 4 comments · Fixed by #511
Closed

.awikstats module missing commas #485

ApertiumBot opened this issue May 16, 2019 · 4 comments · Fixed by #511

Comments

@ApertiumBot
Copy link

This issue was automatically made by begiak, Apertium's beloved IRC bot, by the order of sushain on #apertium. A human is yet to update the description.

@sushain97
Copy link
Member

<firespeaker> .awikstats update sah
<sushain> firespeaker, did that update work?
<firespeaker> sushain: yeah
<firespeaker> though it's not putting commas anymore
<firespeaker> so things look out of whack
<firespeaker> sushain: also, do you remember why I was installing python3-libhfst ?
<firespeaker> oh, it was for selimcan's tests
<sushain> heh
<sushain> commas?
<sushain> http://wiki.apertium.org/wiki/Apertium-sah/stats
<begiak> "No introduction text found." - http://wiki.apertium.org/wiki/Apertium-sah/stats
<sushain> commas in the numbers?
<firespeaker> yeah
<sushain> oh
<firespeaker> sushain: see e.g. http://wiki.apertium.org/wiki/User:Firespeaker
<sushain> .issue apertium/phenny .awikstats module missing commas
<begiak> sushain: Issue created. You can add a description at https://github.com/apertium/phenny/issues/485

@tomasff
Copy link

tomasff commented Dec 8, 2019

Could you be more specific on what the issue is?
I don't quite understand.

Do mean that 9141 should be written as 9,141?

@jonorthwash
Copy link
Member

Do mean that 9141 should be written as 9,141?

Yes.

@tomasff
Copy link

tomasff commented Dec 11, 2019

@jonorthwash I just added a pull request that attempts to fix this. I was unable to test it since I don't have access to the token.

jonorthwash pushed a commit that referenced this issue Dec 15, 2019
* Attempts to fix #485

* Cast statValue to integer

* Remove unecessary integer verification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants