Call it begiak; support case insensitivity; new, working, begiak init script #493
Conversation
Before, .cHoOsE a b did not work. Now it does.
|
This should close #488. |
kj7rrv
changed the title
|
You should revert the commits instead of adding new ones that delete the file and readd it. |
|
Done! This is ready to accept. |
|
Sorry about all the commits on this. I'm new to git. |
Hi, It's a nice opportunity to get introduced to the features of using git. You can read more about branches and pull requests here: |
|
Agreed on the above about one PR for one feature. We aren't so concerned
about the commit history for each PR as it's easy to squash all of the
commits into one, but it's difficult to handle multiple independent
features in a single PR and request for changes to them.
…On Wed, 4 Dec 2019, 17:21 Amr Keleg, ***@***.***> wrote:
Sorry about all the commits on this. I'm new to git.
Hi,
It's a nice opportunity to get introduced to the features of using git.
I would recommend using branches and having multiple pull requests (one
for each issue) instead of fixing multiple issues in the same pull request
(that's my opinion not sure what the maintainers of the repository think).
You can read more about branches and pull requests here:
https://gist.github.com/vlandham/3b2b79c40bc7353ae95a
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#493?email_source=notifications&email_token=AAPZPF5ITZPM7XO53FRH5DLQW5ZALA5CNFSM4JUGBBXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4JIOI#issuecomment-561550393>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPZPF3EC763IBYUDU7MYWTQW5ZALANCNFSM4JUGBBXA>
.
|
|
Okay, can we accept this and I'll do it right in the future? Or will I need to start over? |
| @@ -63,6 +64,7 @@ case "$1" in | |||
| if [ $? -gt 0 ]; then | |||
| exit -1 | |||
| fi | |||
| sleep 1 | |||
There was a problem hiding this comment.
Is there any guarantee that one second will be long enough for begiak to shut down? Wouldn't it be better to wait for it? I believe there are init scripts that check for a certain period of time (120 seconds??) and then kill it if it doesn't shut down? It would be good to see what those init scripts do.
There was a problem hiding this comment.
I think it stops almost instantaneously. It just took longer than the time between two bash commands.
There was a problem hiding this comment.
I think it stops almost instantaneously
Under what conditions? The problem is that begiak runs on a low-powered server that hosts other services, and regardless of that you can't predict what exact conditions it might be subject to on any given system.
|
Closing for now, will reopen as three different PRs. Sorry about the mess. |
No description provided.