Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle clean doesn't use the Gradle wrapper when present #782

Open
3 of 4 tasks
davidmc24 opened this issue Oct 17, 2019 · 0 comments
Open
3 of 4 tasks

Gradle clean doesn't use the Gradle wrapper when present #782

davidmc24 opened this issue Oct 17, 2019 · 0 comments

Comments

@davidmc24
Copy link
Contributor

Prerequisites

  • I am running the latest version. (up upgrade)
  • I searched to see if the issue already exists.
  • I inspected the verbose debug output with the -v, --verbose flag.
  • Are you an Up Pro subscriber?

Description

TLDR: in the javaGradle support in runtimes.go, both the build and clean hooks should check for the availability of the gradle wrapper.

See

func javaGradle(c *Config) {

The default clean hook fails for my project. In particular, my project is a Java Gradle project with the Gradle wrapper installed. I also have a local Gradle installation which is a different version than the wrapper. Due to GradleUp/shadow#287 , the project fails when running with the locally installed version of Gradle, but works when the wrapper is used. By default, up is currently using the wrapper for build, but the locally installed Gradle for clean.

Steps to Reproduce

With a project that uses Gradle and has the wrapper installed, run up deploy -v and see that the clean didn't use the Gradle wrapper.

Love Up?

Please consider signing up for Up Pro (https://up.docs.apex.sh/#guides.subscribing_to_up_pro) or donating via https://opencollective.com/apex-up/donate.

Slack

Join us on Slack https://chat.apex.sh/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant