Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X-axis position of annotations in sparkline #4081

Closed
fedorovvldmr opened this issue Oct 27, 2023 · 0 comments · Fixed by #4331
Closed

X-axis position of annotations in sparkline #4081

fedorovvldmr opened this issue Oct 27, 2023 · 0 comments · Fixed by #4331
Labels
bug Something isn't working

Comments

@fedorovvldmr
Copy link

fedorovvldmr commented Oct 27, 2023 •
edited

Description

In a line graph, the annotation points along the X axis are drawn incorrectly in sparkline mode. If you disable sparkline mode, the annotations are drawn correctly.

Steps to Reproduce

  1. I took an example from the documentation (https://apexcharts.com/docs/annotations/)
  2. I left only point annotations and numbers without dates
  3. the annotation is drawn near the left edge of the graph instead of the middle
  4. if you remove the sparkline mode, the annotation is drawn in the middle

Expected Behavior

An annotation is drawn in the middle of the graph

изображение

Actual Behavior

The annotation is drawn on the left side of the graph

изображение

Reproduction Link

https://codepen.io/fedorovvldmr/pen/mdveZYv
@fedorovvldmr fedorovvldmr added the bug Something isn't working label Oct 27, 2023
rosco54 added a commit to rosco54/apexcharts.js that referenced this issue Mar 19, 2024
@rosco54
Merge Annotations_Y_axis_indexing_fix into Issue_4323_rebasedFix apex…
1961859 
…charts#4323

Multiple-yaxis-scales, 3 series with 2 scales demo was broken
by 3.47.0 after the introduction of the new yaxis:seriesName as an
array feature. Refactored some of that code.

Fixes relating to yaxis.seriesName array feature added to 3.47.0.
Anything that indexes into minYArr[], maxYArr[], baseLineY[],
xyRatios.yRatio[], etc, that doesn't derive from realIndex needed to
map the index through w.globals.seriesYAxisMap[seriesIndex].
Primarily affected y-axis annotations and possibly some other
positioned features in multi-axis charts.

Fix historical issue with goals and annotations being drawn when the
axis is hidden or drawn outside the grid area when zoomed or panned,
or where rect area annotation should be clipped. apexcharts#3073 apexcharts#3553 apexcharts#2757

Miscellaneous:
1) Remove yaxis.min: 0 from the bar axes in sample as not required.
2) Fix several calls to CoreUtils.getLogVal(b,d,seriesIndex) that
were missing the 'b' (base) argument.
3) in getYLogValue(): return  zero if 'd' <= 0 (was 'd' == 0). This may
fix apexcharts#4241.
4) wrong point annotation x position in sparkline chart fix apexcharts#4081.
@rosco54 rosco54 mentioned this issue Mar 19, 2024
Merged
6 tasks
rosco54 added a commit to rosco54/apexcharts.js that referenced this issue Mar 19, 2024
@rosco54
Multiple-yaxis-scales, 3 series with 2 scales demo was broken
9361838 
by 3.47.0 after the introduction of the new yaxis:seriesName as an
array feature. Refactored some of that code.

Fixes relating to yaxis.seriesName array feature added to 3.47.0.
Anything that indexes into minYArr[], maxYArr[], baseLineY[],
xyRatios.yRatio[], etc, that doesn't derive from realIndex needed to
map the index through w.globals.seriesYAxisMap[seriesIndex].
Primarily affected y-axis annotations and possibly some other
positioned features in multi-axis charts.

Fix historical issue with goals and annotations being drawn when the
axis is hidden or drawn outside the grid area when zoomed or panned,
or where rect area annotation should be clipped. apexcharts#3073 apexcharts#3553 apexcharts#2757

Miscellaneous:
1) Remove yaxis.min: 0 from the bar axes in sample as not required.
2) Fix sample syntax not parsed by e2e test harness.
3) Fix several calls to CoreUtils.getLogVal(b,d,seriesIndex) that
were missing the 'b' (base) argument.
4) in getYLogValue(): return  zero if 'd' <= 0 (was 'd' == 0). This may
fix apexcharts#4241.
5) wrong point annotation x position in sparkline chart fix apexcharts#4081.
rosco54 added a commit to rosco54/apexcharts.js that referenced this issue Mar 19, 2024
@rosco54
Multiple-yaxis-scales, 3 series with 2 scales demo was broken
30f2b30 
by 3.47.0 after the introduction of the new yaxis:seriesName as an
array feature. Refactored some of that code.

Fixes relating to yaxis.seriesName array feature added to 3.47.0.
Anything that indexes into minYArr[], maxYArr[], baseLineY[],
xyRatios.yRatio[], etc, that doesn't derive from realIndex needed to
map the index through w.globals.seriesYAxisMap[seriesIndex].

Fix historical issue with goals and annotations being drawn when the
axis is hidden or drawn outside the grid area when zoomed or panned,
or where rect area annotation should be clipped. apexcharts#3073 apexcharts#3553 apexcharts#2757

Fix historical baseLineY not being scaled correctly for logarithmic
yaxis.

Miscellaneous:
1) Remove yaxis.min: 0 from the bar axes in sample as not required.
2) Fix sample syntax not parsed by e2e test harness.
3) Fix several calls to CoreUtils.getLogVal(b,d,seriesIndex) that
were missing the 'b' (base) argument.
4) in getYLogValue(): return  zero if 'd' <= 0 (was 'd' == 0). This may
fix apexcharts#4241.
5) wrong point annotation x position in sparkline chart fix apexcharts#4081.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple-yaxis-scales, 3 series with 2 scales demo was broken by 3.47.0 rosco54/apexcharts.js
1 participant
@fedorovvldmr