Multiple-yaxis-scales, 3 series with 2 scales demo was broken by 3.47.0 #4331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple-yaxis-scales, 3 series with 2 scales demo was broken by 3.47.0 after the introduction of the new yaxis:seriesName as an array feature. Refactored some of that code. Miscellaneous: Remove yaxis.min: 0 from the bar axes in sample as not required.
|
This replaces the previous PR #4329 that was incorrectly based. |
Multiple-yaxis-scales, 3 series with 2 scales demo was broken by 3.47.0 after the introduction of the new yaxis:seriesName as an array feature. Refactored some of that code. Fixes relating to yaxis.seriesName array feature added to 3.47.0. Anything that indexes into minYArr[], maxYArr[], baseLineY[], xyRatios.yRatio[] that doesn't derive from realIndex needed to go through w.globals.seriesYAxisMap. Primarily affected y-axis annotations and possibly some other positioned features in multi-axis charts. Miscellaneous: Remove yaxis.min: 0 from the bar axes in sample as not required.
rosco54
force-pushed
the
Issue_4323_rebased
branch
4 times, most recently
from
1961859
to
9361838
Compare
|
@junedchhipa Can you give me a clue re the baseLineY value that is used in translating into SVG grid coordinate space. I haven't been able to determine how that value is derived but it throws out the alignment of logarithmic plots and yet is ok for linear plots. At the moment I'm just substituting zero for log plots. Update: It's ok. I've got it, and have fixed the root problem. baseLineY is now adjusted for logarithmic yaxes. |
rosco54
force-pushed
the
Issue_4323_rebased
branch
from
9361838
to
30f2b30
Compare
by 3.47.0 after the introduction of the new yaxis:seriesName as an array feature. Refactored some of that code. Fixes relating to yaxis.seriesName array feature added to 3.47.0. Anything that indexes into minYArr[], maxYArr[], baseLineY[], xyRatios.yRatio[], etc, that doesn't derive from realIndex needed to map the index through w.globals.seriesYAxisMap[seriesIndex]. Fix historical issue with goals and annotations being drawn when the axis is hidden or drawn outside the grid area when zoomed or panned, or where rect area annotation should be clipped. apexcharts#3073 apexcharts#3553 apexcharts#2757 Fix historical baseLineY not being scaled correctly for logarithmic yaxis. Miscellaneous: 1) Remove yaxis.min: 0 from the bar axes in sample as not required. 2) Fix sample syntax not parsed by e2e test harness. 3) Fix several calls to CoreUtils.getLogVal(b,d,seriesIndex) that were missing the 'b' (base) argument. 4) in getYLogValue(): return zero if 'd' <= 0 (was 'd' == 0). This may fix apexcharts#4241. 5) wrong point annotation x position in sparkline chart fix apexcharts#4081.
rosco54
force-pushed
the
Issue_4323_rebased
branch
from
30f2b30
to
686266c
Compare
junedchhipa
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
Fixes relating to yaxis.seriesName array feature added at revision 3.47.0:
Fix historical issue with goals and annotations being drawn when the axis is hidden or outside the grid area when zoomed or panned, or where rectangular area annotation should be clipped.
Fix historical issue: baseLineY calculation not adjusted for logarithmic y axes.
Miscellaneous:
Fixes #2757
Fixes #3073
Fixes #3421
Fixes #3553
Fixes #4081
Fixes #4241 (maybe)
Fixes #4323
Type of change
Checklist: