-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sunrise_time does not update time value for requested time zone #7
Comments
Many thanks for this report! |
I suspect the problem has to do with the change in 'lubridate' from |
This guess was wrong. The problem stems at least in part from the use of |
'lubridate' 1.8.0 broke handling of time zones in sunrise_time(). Working now for time vectors or Date vectors of length 1. Issue #7
Pending testing with earlier versions, now these new versions of lubridate and tibble are the minimum supported. This version fixes the bug reported in issue #7 for sunrise_time(), affecting also day_night(), sunset_time() and noon_time().
Added unit tests and tested with 'lubridate' 1.7.8, 1.7.9.2 and 1.8.0. Tested with 'tibble' 3.1.0 and 3.1.7. All under R 4.2.1. The previously buggy functions now return the correct values in all cases, independently of input being a |
It is fixed for me. Thanks for the rapid response, and many thanks for developing a very useful package! |
You are welcome! Once again thanks for reporting the problem! |
It seems
sunrise_time
is not correct for non-UTC times with recent versions of lubridate or R, as shown in the User Guide.However, regressing to earlier versions of lubridate and R but using the same photobiology version results in the correct time.
The text was updated successfully, but these errors were encountered: