Skip to content

Commit

Permalink
i965/gen9: Set vertical and horizontal surface alignments
Browse files Browse the repository at this point in the history
Patch sets the alignments for texture and renderbuffer surfaces.

V3: Make changes inside horizontal_alignment() and
    vertical_alignment() (Topi)

Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
Reviewed-by: Topi Pohjolainen <topi.pohjolainen@intel.com>
  • Loading branch information
aphogat committed Jun 16, 2015
1 parent 6c380d4 commit 54591bb
Showing 1 changed file with 26 additions and 6 deletions.
32 changes: 26 additions & 6 deletions src/mesa/drivers/dri/i965/gen8_surface_state.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,18 @@ surface_tiling_mode(uint32_t tiling)
}

static unsigned
vertical_alignment(const struct intel_mipmap_tree *mt)
vertical_alignment(const struct brw_context *brw,
const struct intel_mipmap_tree *mt,
uint32_t surf_type)
{
/* On Gen9+ vertical alignment is ignored for 1D surfaces and when
* tr_mode is not TRMODE_NONE.
*/
if (brw->gen > 8 &&
(mt->tr_mode != INTEL_MIPTREE_TRMODE_NONE ||
surf_type == BRW_SURFACE_1D))
return 0;

switch (mt->align_h) {
case 4:
return GEN8_SURFACE_VALIGN_4;
Expand All @@ -98,8 +108,18 @@ vertical_alignment(const struct intel_mipmap_tree *mt)
}

static unsigned
horizontal_alignment(const struct intel_mipmap_tree *mt)
horizontal_alignment(const struct brw_context *brw,
const struct intel_mipmap_tree *mt,
uint32_t surf_type)
{
/* On Gen9+ horizontal alignment is ignored when tr_mode is not
* TRMODE_NONE.
*/
if (brw->gen > 8 &&
(mt->tr_mode != INTEL_MIPTREE_TRMODE_NONE ||
gen9_use_linear_1d_layout(brw, mt)))
return 0;

switch (mt->align_w) {
case 4:
return GEN8_SURFACE_HALIGN_4;
Expand Down Expand Up @@ -210,8 +230,8 @@ gen8_emit_texture_surface_state(struct brw_context *brw,

surf[0] = SET_FIELD(surf_type, BRW_SURFACE_TYPE) |
format << BRW_SURFACE_FORMAT_SHIFT |
vertical_alignment(mt) |
horizontal_alignment(mt) |
vertical_alignment(brw, mt, surf_type) |
horizontal_alignment(brw, mt, surf_type) |
tiling_mode;

if (surf_type == BRW_SURFACE_CUBE) {
Expand Down Expand Up @@ -438,8 +458,8 @@ gen8_update_renderbuffer_surface(struct brw_context *brw,
surf[0] = (surf_type << BRW_SURFACE_TYPE_SHIFT) |
(is_array ? GEN7_SURFACE_IS_ARRAY : 0) |
(format << BRW_SURFACE_FORMAT_SHIFT) |
vertical_alignment(mt) |
horizontal_alignment(mt) |
vertical_alignment(brw, mt, surf_type) |
horizontal_alignment(brw, mt, surf_type) |
surface_tiling_mode(tiling);

surf[1] = SET_FIELD(mocs, GEN8_SURFACE_MOCS) | mt->qpitch >> 2;
Expand Down

0 comments on commit 54591bb

Please sign in to comment.