Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 6.0 #4543

Closed
4 tasks done
dunglas opened this issue Nov 9, 2021 · 3 comments
Closed
4 tasks done

Support Symfony 6.0 #4543

dunglas opened this issue Nov 9, 2021 · 3 comments
Projects

Comments

@dunglas
Copy link
Member

dunglas commented Nov 9, 2021

Now that we support Symfony 5.4, we must also support Symfony 6.0.

  • Checkout the 2.6 branch
  • Add allow the ^6.0 version for all Symfony projects
  • Run the test suite
  • Remove the annoying type hints from Symfony's interfaces (open PR and ping me)
@dunglas dunglas added this to To do in Hackathon Nov 9, 2021
@leeroynico
Copy link

I work on it

@Chris53897
Copy link
Contributor

Chris53897 commented Nov 13, 2021

This ticket is not so easy. I will try to help with this.
I think 2 steps are necessary in my point of view.

  1. Build a Pipeline and allow symfony 6 in dependencies to get an overview of how much work is needed to support symfony 6.
  2. Decide if APIP 2.x needs support for Symfony 6. Or only APIP 3.x with PHP8. Because you can not make a project compatible with Symfony 6 if you do not require Php >8. At least i do not know a way to do this.

To 1)

The CI Pipeline will not test all symfony 6 packages. Symfony 6.0 needs to be added to the test-matrix on 2 places (this allows the 2 additional packages to be tested against 6.0. Example Test-Run

Some symfony components are sticked to 5.4 because of dependencies.
(The link mink-repo is merged now, but the tests are not covering symfony 6.)

Example:
composer why symfony/browser-kit
...
friends-of-behat/mink-browserkit-driver v1.5.0 requires symfony/browser-kit (^4.4|^5.0)

I made a PR draft
and will try to update b) PR.
a) Origin https://github.com/minkphp/driver-testsuite (is still supporting Php > 5.6)
b) Fork of a) https://github.com/FriendsOfBehat/driver-testsuite (is used in friends-of-behat/mink-browserkit-driver)

nicolas-grekas added a commit to symfony/symfony that referenced this issue Dec 1, 2021
…latform compatibility (PierreRebeilleau)

This PR was merged into the 6.0 branch.

Discussion
----------

[Serializer] Remove DecoderInterface type hint for API Platform compatibility

…tibility

| Q             | A
| ------------- | ---
| Branch?       |6.0 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix api-platform/core#4543 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

After : #44331
Hello, I discovered that a type hint in DecoderInterface is not compatible for API Platform and i didn't saw it, if it's not too late i would like to revert it.

Commits
-------

3dc5da1 [Serializer] Remove DecoderInterface type hint for API Platform compatibility
@Chris53897
Copy link
Contributor

update:
One blocker is gone.
Here i wait for a new release.
minkphp/Mink#814

After that "soyuka/contexts" could be updated too.

Now that 6.x is stable the CI Tests should be easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants