feat: Add symfony 6 compatibility #4582
Conversation
PierreRebeilleau
changed the title
|
symfony/symfony#44331 is merged, is it possible to execute the quality checks again? |
|
Hi, was looking if I could help out a bit so did some digging through requirements in SF 3.4 LTS is now past EOL (since this month). Also, SF 3.4 has Extra question: is there somewhere I can see/look into/help efforts for a possible v3 and/or minimum PHP 8 / 8.1 requirement? |
|
I would prefer to drop Symfony 3.4/PHP 7.1 in the main branch. But if it's too annoying to keep supporting them, then let's bump these minimal versions. The main branch contains the 2.7 version, which will be the same code as 3.0 but with a backward compatibility layer for API Platform 2 (that we'll drop before tagging 3.0). |
| @@ -125,6 +129,10 @@ protected function setAttributeValue($object, $attribute, $value, $format = null | |||
| $attribute = 'id'; | |||
| } | |||
|
|
|||
| if ('{}' === $value) { | |||
There was a problem hiding this comment.
That's weird. Why do we need this?
There was a problem hiding this comment.
When we dump dump($context['args']['input']); in the DeserializeStage we got this :
array:4 [
"id" => "/related_dummies/2"
"symfony" => "laravel"
"thirdLevel" => "/third_levels/1"
"embeddedDummy" => "{}"
]
There was a problem hiding this comment.
This looks like a bug in pho-GraphQL. Could you report it upstream and explain why we need this temporary fix in a comment please?
There was a problem hiding this comment.
Input is user-defined, there shouldn't be a fix in the serializer. Maybe the test is bad. Which test is failing?
There was a problem hiding this comment.
https://github.com/api-platform/core/runs/4595101310?check_suite_focus=true
Seems to be this one
There was a problem hiding this comment.
This is strange, we need to dig it, it's probably not the right fix.
| @@ -808,49 +808,18 @@ public function testDisabledPaginationViaDefaults() | |||
|
|
|||
| public function testItLoadsMetadataConfigFileInAlphabeticalOrder() | |||
| { | |||
| $yamlExtractorDefinition = $this->prophesize(Definition::class); | |||
|
Thank you everyone. |
|
You rock! |
Test are failing because of some type hinting, waiting for a new release of symfony 6 , solved by symfony/symfony#44331