Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swagger generation for array parameters #2114

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

ossinkine
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1985
License MIT

Search filter adds array parameter like key[] to swagger documentation but type of this parameter is string. This PR fixes it.

@ossinkine ossinkine force-pushed the issue-2114 branch 2 times, most recently from e246963 to 8d0dbea Compare July 19, 2018 11:36
@soyuka
Copy link
Member

soyuka commented Jul 25, 2018

As this is a bug fix, could you change the target branch to 2.3? Thanks!

@ossinkine ossinkine changed the base branch from master to 2.3 July 25, 2018 11:06
@ossinkine
Copy link
Contributor Author

@soyuka Updated

@dunglas dunglas merged commit f07f251 into api-platform:2.3 Sep 11, 2018
@dunglas
Copy link
Member

dunglas commented Sep 11, 2018

Good catch @ossinkine! Thanks for fixing this.
Do you think that you can add a new test for the DocumentationNormalizer class to prevent any future reflection?

@ossinkine
Copy link
Contributor Author

@dunglas Maybe but not soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants