Add Swagger DocumentationNormalizer test for array collection filters #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Oct 6, 2018
teohhanhui
reviewed
Oct 6, 2018
| ]; | ||
|
|
||
| foreach ($filters as $filterId => $filter) { | ||
| $filterLocatorProphecy->has($filterId)->willReturn(true)->shouldBeCalled(); | ||
| $filterLocatorProphecy->get($filterId)->willReturn($filter)->shouldBeCalled(); | ||
| } | ||
|
|
||
| $filterLocatorProphecy->has('f3')->willReturn(false)->shouldBeCalled(); | ||
| $filterLocatorProphecy->has('f4')->willReturn(false)->shouldBeCalled(); |
There was a problem hiding this comment.
Not a fault of this PR, but ->shouldBeCalled() should only be used when we actually want to check that a method is called. If the intention is only to mock the return value of the method, ->willReturn(...) should suffice.
teohhanhui
approved these changes
Oct 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a merged PR #2114 but this part wasn't tested yet, so I added the test in the case of an array collection filters in the Swagger documentation.