Allow custom operations to return a different class than the expected resource class #2861
Conversation
teohhanhui
commented
Jun 14, 2019
•
teohhanhui
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #2855, api-platform/api-platform#1172 |
| License | MIT |
| Doc PR | N/A |
teohhanhui
force-pushed
the
fix/custom-operation-return-different-class
branch
from
b2c623b
to
5af92ed
Compare
|
this obviously begs the question, what is |
teohhanhui
force-pushed
the
fix/custom-operation-return-different-class
branch
3 times, most recently
from
db0a45d
to
a7433d4
Compare
teohhanhui
force-pushed
the
fix/custom-operation-return-different-class
branch
from
a7433d4
to
9223ebb
Compare
| /** | ||
| * @var string | ||
| */ | ||
| private $amount; |
There was a problem hiding this comment.
Not mapped as Doctrine MongoDB ODM does not have a decimal type. I'm not sure what's the right thing to do here... If I use type="float", the type validation fails during denormalization.
There was a problem hiding this comment.
| @@ -2,10 +2,13 @@ Feature: Custom operation | |||
| As a client software developer | |||
| I need to be able to create custom operations | |||
|
|
|||
| Background: | |||
There was a problem hiding this comment.
oh this is nice, does this allow to add steps to every scenario?
No. But I don't think we should deprecate it either? There are tests that use it so it's at least covered. |
Hmm yeah leave it like this, at first I thought that this class was |
