Fix deprecations

[bendavies]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#2896
License	MIT
Doc PR

We can't use max[total]=0

The remaining ones are:

Remaining indirect deprecation notices (5)

  1x: The "FOS\UserBundle\Controller\SecurityController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.
    1x in BooleanFilterTest::setUp from ApiPlatform\Core\Tests\Bridge\Doctrine\Orm\Filter

  1x: The "FOS\UserBundle\Controller\ProfileController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.
    1x in BooleanFilterTest::setUp from ApiPlatform\Core\Tests\Bridge\Doctrine\Orm\Filter

  1x: The "FOS\UserBundle\Controller\RegistrationController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.
    1x in BooleanFilterTest::setUp from ApiPlatform\Core\Tests\Bridge\Doctrine\Orm\Filter

  1x: The "FOS\UserBundle\Controller\ChangePasswordController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.
    1x in BooleanFilterTest::setUp from ApiPlatform\Core\Tests\Bridge\Doctrine\Orm\Filter

  1x: The "FOS\UserBundle\Controller\ResettingController" class extends "Symfony\Bundle\FrameworkBundle\Controller\Controller" that is deprecated since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.
    1x in BooleanFilterTest::setUp from ApiPlatform\Core\Tests\Bridge\Doctrine\Orm\Filter

What about all the legacy deprecations like this? Remove in 3.0? I think another PR is needed to standardise the deprecation messages.
https://github.com/api-platform/core/blob/master/src/Bridge/Doctrine/Orm/Filter/AbstractFilter.php#L49-L51

[dunglas]

@bendavies can we close this one now that #2920 has been merged?

[bendavies]

I don't think so? This targets 2.5 and symfony 4.3?

[teohhanhui]

@bendavies With #2925 we could aim for full Symfony 4.3 compatibility in 2.4.

[bendavies]

ah yes, i forgot only messenger 4.3 is not supported.

Anyway, i'm not sure about #2920 as it introduces the password algorithm deprecation that i am removing here. bcrypt is deprecated, and should be auto?