Add consistency for the maximum_items_per_page option. #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Sep 23, 2019
| $maxItemsPerPage = $resourceMetadata->getCollectionOperationAttribute($operationName, 'pagination_maximum_items_per_page', $maxItemsPerPage, true); | ||
|
|
||
| if (null !== $maxItemsPerPage) { | ||
| $itemPerPageParameter['schema']['maximum'] = $maxItemsPerPage; |
There was a problem hiding this comment.
That's what I thought at first... but #3050 (comment)
|
Should we merge this on 2.5? Some ci are failing? |
|
See #3088. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
pagination_maximum_items_per_pageas the new source of truth for hard-limiting the number of items in a resultset.Former attribute
maximum_items_per_pagestill works as a fallback with a deprecation notice when used.