-
-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IriConverter without output with new attribute #3224
Use IriConverter without output with new attribute #3224
Conversation
Allow to have content-location without output if output is set to false and set_content_location is set to true #hackdayparis
81b3e1a
to
fdebcac
Compare
This attribute must also be added to https://github.com/api-platform/core/blob/master/src/Annotation/ApiResource.php#L69 for the Developer Experience. Sorry I forgot about that yesterday :(. Could you add it please? |
@dunglas isn't this a fix though? |
No it's a new feature. |
it is only for documentation purpose ? Currently, without any modification I can use the attribute for all operations like this :
Or for a specific operation like this :
If I declare the attribute as annotation, the declaration could change and it will be logic (I think) to use the attribute like this :
But I didn't find a way to retrieve the value with this declaration and the method |
Another observation : every attributes annotated are in camelCase so if I have to add it and use it differently, I should convert it to camelcase ? And, given that the content-location will be set only for write actions by the |
Should we update this PR @dunglas? It would great to have a use case (a PR in the docs would be nice). |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Allow to have content-location without output if output is set to false and set_content_location (the new attribute) is set to true
#hackdayparis