Fixed an error where an exception was thrown if the messenger input data has an id field

[karser]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tickets	fixes #...
License	MIT

How to reproduce:

#api_resources.yaml:
App\Dto\DummyWithIdField:
    attributes:
        messenger: true
        output: false
    collectionOperations:
        post:
            path: '/path/to/dummy'
            status: 202
    itemOperations: {}

namespace App\Dto;

class DummyWithIdField {
    /** @var string|null */
    public $id;
}

curl --location --request POST 'https://api.domain.com/path/to/dummy' \
--header 'Content-Type: application/json' \
--data-raw '{"id":"ev_16CHO7Rt6vyOp8ng"}
'

The error in response:

{
    "@context": "/contexts/Error",
    "@type": "hydra:Error",
    "hydra:title": "An error occurred",
    "hydra:description": "Update is not allowed for this operation.",
    "trace": [
        {
            "namespace": "",
            "short_class": "",
            "class": "",
            "type": "",
            "function": "",
            "file": "vendor/api-platform/core/src/Serializer/ItemNormalizer.php",
            "line": 59,
            "args": []
        },

The entire stacktrace https://gist.github.com/karser/9425657bff25da4026591e6af6e227fb

[soyuka]

$this->resourceMetadataFactory->create($class)

may be null

[karser]

(true || x) will never evaluate x

[soyuka]

Not resourceMetadataFactory I mean the result of calling create can be null https://3v4l.org/18tE1 ?

[karser]

Sorry, got it

[karser]

Fixed it

[soyuka]

can you rebase on 2.5 ?

[karser]

I rebased against 2.5

[teohhanhui]

I'm sorry, but this doesn't seem like the right fix at all.

[teohhanhui]

If there is a bug, we should address the core issue. This workaround is wrong.

[soyuka]

IMO the isset($data['data']['id']) check is already a wrong assumption, if we can avoid messenger to go through this check it simplifies some cases. I already hit that bug but can't remember what I did to fix it.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.