Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check change tracking deferred for ODM #3629

Merged
merged 3 commits into from
Aug 4, 2020
Merged

Check change tracking deferred for ODM #3629

merged 3 commits into from
Aug 4, 2020

Conversation

Jean-Beru
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tickets
License MIT
Doc PR

DataPersister checks change tracking policy before persisting it. It works only with ORM since ODM metadata class is not the same. The aim of this PR is to fix it.

@dunglas dunglas requested a review from alanpoulain July 10, 2020 12:49
@soyuka
Copy link
Member

soyuka commented Jul 23, 2020

I rebased your pull request but the phpunit test fail https://github.com/api-platform/core/pull/3629/checks?check_run_id=902984718 is related to this code

@Jean-Beru
Copy link
Contributor Author

Good catch. ClassMetadata::isChangeTrackingDeferredExplicit does not exist in this ODM version. So, I've just added a check in my test.

@alanpoulain alanpoulain merged commit 1d45d79 into api-platform:2.5 Aug 4, 2020
@alanpoulain
Copy link
Member

Thank you @Jean-Beru!

@Jean-Beru Jean-Beru deleted the bugfix/isDeferredExplicit-for-ODM branch August 4, 2020 10:38
nightio pushed a commit to nightio/core that referenced this pull request Aug 14, 2020
@Jean-Beru @nightio
Check change tracking deferred for ODM (api-platform#3629)
5e15eca
dunglas added a commit that referenced this pull request Aug 22, 2020
@dunglas
Merge branch '2.5' into master
38d69e6 
* 2.5:
  fix: Order filter log when the property is invalid (#3673)
  Merge #3529 and #3671 (#3675)
  Check change tracking deferred for ODM (#3629)
  Changed depth and maxDepth handling for selfreferencing subresourceOp… (#3616)
  [GraphQL] No BC for types (#3654)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@alanpoulain alanpoulain alanpoulain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jean-Beru @soyuka @alanpoulain @dunglas