Fixing error for none database identifiers Api ids (with tests) #3671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2020
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Aug 12, 2020
commit b5fcf46 Author: soyuka <soyuka@users.noreply.github.com> Date: Wed Aug 12 16:02:51 2020 +0200 fix phpstan commit 0cbc7e2 Author: Arnaud J <jabin@cikaba.com> Date: Sat Aug 8 16:35:09 2020 +0200 :white_check_mark: Test API subresources with custom identifiers commit d741950 Author: mahmood bazdar <mahmood.bazdar@gmail.com> Date: Mon Apr 27 15:29:01 2020 +0430 Fixing error for none database identifiers Api ids
soyuka
added a commit
that referenced
this pull request
Aug 12, 2020
commit b5fcf46 Author: soyuka <soyuka@users.noreply.github.com> Date: Wed Aug 12 16:02:51 2020 +0200 fix phpstan commit 0cbc7e2 Author: Arnaud J <jabin@cikaba.com> Date: Sat Aug 8 16:35:09 2020 +0200 :white_check_mark: Test API subresources with custom identifiers commit d741950 Author: mahmood bazdar <mahmood.bazdar@gmail.com> Date: Mon Apr 27 15:29:01 2020 +0430 Fixing error for none database identifiers Api ids
nightio
pushed a commit
to nightio/core
that referenced
this pull request
Aug 14, 2020
commit b5fcf46 Author: soyuka <soyuka@users.noreply.github.com> Date: Wed Aug 12 16:02:51 2020 +0200 fix phpstan commit 0cbc7e2 Author: Arnaud J <jabin@cikaba.com> Date: Sat Aug 8 16:35:09 2020 +0200 :white_check_mark: Test API subresources with custom identifiers commit d741950 Author: mahmood bazdar <mahmood.bazdar@gmail.com> Date: Mon Apr 27 15:29:01 2020 +0430 Fixing error for none database identifiers Api ids
dunglas
added a commit
that referenced
this pull request
Aug 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for #3529 as asked by @soyuka