Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix 2.7 behat tests #5953

Closed
wants to merge 7 commits into from

Conversation

vasilvestre
Copy link

@vasilvestre vasilvestre commented Nov 8, 2023

Q A
Branch? 2.7
Tickets none
License MIT

Reasons for changes :

Composer

Use the same composer dependencies changes in behat and phpunit

HAL

Don't rely on insertion #5709

JsonLD

Don't rely on insertion #5709

GraphQL

Add some missing operations

Need help

Mercure

The Mercure update sent is made with json+ld instead of simple json so it fails to match format.
features/graphql/subscription.feature:187

"{"@context":"\/contexts\/DummyMercure","@id":"\/dummy_mercures\/1","@type":"DummyMercure","id":1,"name":"Dummy Mercure #1 updated","description":"Description","relatedDummy":"\/related_dummies\/1"}"
"{"dummyMercure":{"id":1,"name":"Dummy Mercure #1 updated","relatedDummy":{"name":"RelatedDummy #1"}}}"

Subresource

features/main/subresource.feature:476
On PHP 8.*, value of offers and relatedProducts keys from DummyProduct are empty.

features/main/subresource.feature:401
On PHP 8.*, hydra:member is empty instead of containing a DummyOffer

Copy link

stale bot commented Jan 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 14, 2024
@vasilvestre
Copy link
Author

I couldn't succeed :(

@stale stale bot removed the stale label Jan 15, 2024
@vasilvestre
Copy link
Author

The branch changed a lot since my fixes, I'm closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants