fix(symfony): documentation request _format #6390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/openapi-format
branch
3 times, most recently
from
c0f16a6
to
ff451da
Compare
soyuka
force-pushed
the
fix/openapi-format
branch
from
ff451da
to
865ff00
Compare
soyuka
commented
May 27, 2024
| @@ -432,3 +432,9 @@ Feature: Documentation support | |||
| ] | |||
| """ | |||
| And the JSON node "components.schemas.DummyBoolean.properties.isDummyBoolean.owl:maxCardinality" should not exist | |||
|
|
|||
| Scenario: Retrieve the OpenAPI documentation in JSON | |||
| Given I add "Accept" header equal to "text/html,*/*;q=0.8" | |||
There was a problem hiding this comment.
@bendavies note that browsers are sending */* without that we always control the Accept header before the .{_format} and we'd get a 406.
There was a problem hiding this comment.
@soyuka i'm not sure what you mean sorry.
|
@soyuka can we have a release for this? thanks! |
|
sorry tried tonight but wasn't able to (needed to catch up on api-platform/api-platfom) will try again tomorrow! |
|
done ! |
|
thankyou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6372