feat: complete doctrine bridge tests #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Simperfit
commented
Aug 13, 2016
•
Simperfit
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
- Add test for WriteListener
- Complete Util Test
- Add test for Collection Data Provider -> I will make it later in another PR
Simperfit
force-pushed
the
feature/add-test-for-doctrine
branch
2 times, most recently
from
1f19301
to
497ba9e
Compare
Simperfit
changed the title
Simperfit
force-pushed
the
feature/add-test-for-doctrine
branch
3 times, most recently
from
11f6488
to
e2c422d
Compare
| use Symfony\Component\HttpKernel\HttpKernelInterface; | ||
|
|
||
| /** | ||
| * Class WriteListenerTest. |
Simperfit
force-pushed
the
feature/add-test-for-doctrine
branch
from
e2c422d
to
705ea46
Compare
Simperfit
force-pushed
the
feature/add-test-for-doctrine
branch
from
705ea46
to
ad8cd03
Compare
Simperfit
changed the title
|
@dunglas This can be merged. Ill make another PR later on for item/collection providers |
|
Thanks Hamza! |
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.