Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage #697

Merged
merged 9 commits into from
Aug 25, 2016
Merged

Increase code coverage #697

merged 9 commits into from
Aug 25, 2016

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Aug 24, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 83.851% when pulling 2b6dd3c on dunglas:coverage into 0f7ec87 on api-platform:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 83.851% when pulling fac1c7d on dunglas:coverage into 0f7ec87 on api-platform:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 83.851% when pulling a56c3ff on dunglas:coverage into 0f7ec87 on api-platform:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 84.052% when pulling 42d1bb5 on dunglas:coverage into 0f7ec87 on api-platform:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 84.113% when pulling a26d621 on dunglas:coverage into 0f7ec87 on api-platform:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.02%) to 84.504% when pulling 35f1498 on dunglas:coverage into 0f7ec87 on api-platform:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 84.75% when pulling 35f1498 on dunglas:coverage into 0f7ec87 on api-platform:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 85.089% when pulling a394182 on dunglas:coverage into c605269 on api-platform:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.1%) to 87.563% when pulling d63aa99 on dunglas:coverage into c605269 on api-platform:master.

"symfony/doctrine-bridge": "^2.8 || ^3.0",
"symfony/phpunit-bridge": "^2.7 || ^3.0",
"symfony/security": "^2.7 || ^3.0",
"symfony/validator": "^2.7 || ^3.0",
"symfony/finder": "^2.7 || ^3.0"
"symfony/finder": "^2.7 || ^3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really should enforce sorted dependencies so that we can stop mucking around with where they should "logically" be placed "correctly"... 😆

@dunglas dunglas merged commit 29ef103 into api-platform:master Aug 25, 2016
@dunglas dunglas deleted the coverage branch August 25, 2016 21:50
magarzon pushed a commit to magarzon/core that referenced this pull request Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants