-
-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase code coverage #697
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
57558a6
Add more unit tests for metadata
dunglas 79bd021
Test that Swagger UI is present
dunglas d7a8022
Add AnnotationPropertyNameCollectionFactoryTest
dunglas 8a70eca
Unit test and fix the FOSUser bridge
dunglas 6d6a833
Add a functionnal test for the Entrypoint context
dunglas a394182
Add AnnotationResourceMetadataFactoryTest
dunglas d63aa99
Fix NelmioApiDoc support and add test
dunglas 4add6ba
Add CollectionFiltersNormalizerTest
dunglas 056a63f
Merge coverage using phpcov
dunglas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
Feature: Entrypoint support | ||
In order to build an auto-discoverable API | ||
As a client software developer | ||
I need to access to an entrypoint listing top-level resources | ||
|
||
Scenario: Retrieve the Entrypoint | ||
When I send a "GET" request to "/" | ||
Then the response status code should be 200 | ||
And the response should be in JSON | ||
And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8" | ||
And the JSON node "@context" should be equal to "/contexts/Entrypoint" | ||
And the JSON node "@id" should be equal to "/" | ||
And the JSON node "@type" should be equal to "Entrypoint" | ||
And the JSON node "abstractDummy" should be equal to "/abstract_dummies" | ||
And the JSON node "circularReference" should be equal to "/circular_references" | ||
And the JSON node "compositeItem" should be equal to "/composite_items" | ||
And the JSON node "compositeLabel" should be equal to "/composite_labels" | ||
And the JSON node "compositeRelation" should be equal to "/composite_relations" | ||
And the JSON node "concreteDummy" should be equal to "/concrete_dummies" | ||
And the JSON node "customIdentifierDummy" should be equal to "/custom_identifier_dummies" | ||
And the JSON node "customNormalizedDummy" should be equal to "/custom_normalized_dummies" | ||
And the JSON node "customWritableIdentifierDummy" should be equal to "/custom_writable_identifier_dummies" | ||
And the JSON node "dummy" should be equal to "/dummies" | ||
And the JSON node "relatedDummy" should be equal to "/related_dummies" | ||
And the JSON node "relationEmbedder" should be equal to "/relation_embedders" | ||
And the JSON node "thirdLevel" should be equal to "/third_levels" | ||
And the JSON node "user" should be equal to "/users" | ||
And the JSON node "fileconfigdummy" should be equal to "/fileconfigdummies" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
Feature: NelmioApiDoc integration | ||
In order to use NelmioApiDocBundle | ||
As an API software developer | ||
I need to see the generated documentation | ||
|
||
Scenario: Create a user | ||
When I send a "GET" request to "/nelmioapidoc" | ||
Then the response status code should be 200 | ||
And I should see text matching "AbstractDummy" | ||
And I should see text matching "Dummy" | ||
And I should see text matching "User" | ||
And I should see text matching "Retrieves the collection of Dummy resources." | ||
And I should see text matching "Creates a Dummy resource." | ||
And I should see text matching "Deletes the Dummy resource." | ||
And I should see text matching "Replaces the Dummy resource." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really should enforce sorted dependencies so that we can stop mucking around with where they should "logically" be placed "correctly"... 😆