Allow integers instead of floats for JSON. Fix #37. #714
Conversation
dunglas
commented
Aug 30, 2016
•
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | api-platform/api-platform#37 |
| License | MIT |
| Doc PR | n/a |
|
Tests failures related to willdurand/Negotiation#84, not to this patch. I'll send another PR to fix them tonight. |
| $builtinType = $type->getBuiltinType(); | ||
| if (!call_user_func('is_'.$builtinType, $value)) { | ||
| if (false !== strpos($format, 'json') && Type::BUILTIN_TYPE_FLOAT === $builtinType) { |
There was a problem hiding this comment.
The format check is unreliable and hackish...
There was a problem hiding this comment.
Do you have a better idea? It is simple and can be easily documented.
There was a problem hiding this comment.
This is special handling for JSON, but what about other formats that we do not know about? Ideally the Normalizer shouldn't care about such things, right?
There was a problem hiding this comment.
Other formats: it's why the method is protected. An alternative is to have a dedicated abstract JsonNormalizer but it looks overkill for now. Currently, we only support JSON based formats (the XML support is poor and buggy, and we have no other format supported).
There was a problem hiding this comment.
The same validation would occur without checking the format no? I don't see why this would be json-specific.
There was a problem hiding this comment.
No, it's a specificity of JSON to have a generic Number type. Other formats generally make the distinction between int and float.
…rializing JSON (dunglas) This PR was squashed before being merged into the 3.1 branch (closes #21165). Discussion ---------- [Serializer] int is valid when float is expected when deserializing JSON | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | api-platform/api-platform#37 | License | MIT | Doc PR | n/a JSON only has a Number type corresponding to both `int` and `float` PHP types. PHP's `json_encode`, JavaScript's `JSON.stringify`, Go's `json.Marshal` as well as most other JSON encoders convert floating-point numbers like `12.0` to `12` (the decimal part is dropped when possible). PHP's `json_decode` automatically converts Numbers without a decimal part to integers. Actually, the Serializer rejects integers when a float is expected, this PR fixes this behavior when denormalizing JSON-based formats. Port of api-platform/core#714. /cc @gorghoa @Shine-neko Commits ------- 4125455 [Serializer] int is valid when float is expected when deserializing JSON
Allow integers instead of floats for JSON. Fix api-platform#37.
