Fix swagger basePath #725
Fix swagger basePath #725
Conversation
GuilhemN
commented
Sep 5, 2016
GuilhemN
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #722 |
| License | MIT |
| Doc PR |
|
|
||
| public function __construct(ResourceMetadataFactoryInterface $resourceMetadataFactory, PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory, PropertyMetadataFactoryInterface $propertyMetadataFactory, ResourceClassResolverInterface $resourceClassResolver, OperationMethodResolverInterface $operationMethodResolver, OperationPathResolverInterface $operationPathResolver) | ||
| public function __construct(ResourceMetadataFactoryInterface $resourceMetadataFactory, PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory, PropertyMetadataFactoryInterface $propertyMetadataFactory, ResourceClassResolverInterface $resourceClassResolver, OperationMethodResolverInterface $operationMethodResolver, OperationPathResolverInterface $operationPathResolver, RequestContext $requestContext) |
There was a problem hiding this comment.
if you prefer, we can provide easily a bc layer by instantiating the request context with its default values.
There was a problem hiding this comment.
We don't care about BC for now, so it's ok :)
There was a problem hiding this comment.
However adding a dependency to the Symfony Router in this component is not ok.
There was a problem hiding this comment.
arf indeed... we could have something like a proxy to the RequestContext?
There was a problem hiding this comment.
Or we can do this in the RouterOperationPathResolver but then resolvers result won't be consistent anymore.
There was a problem hiding this comment.
Or maybe better, in the normalizer:
if ($this->operationPathResolver instanceof RouterOperationPathResolver) {
$doc['basePath'] = $this->operationPathResolver->getContext()->getBaseUrl();
}What do you prefer?
|
An alternative (maybe cleaner) would be to allow to inject the WDYT @Ener-Getick? |
|
Thanks for working on this @Ener-Getick! |
|
You're welcome :) |
