Fix #673: name converter for Swagger and NelmioApiDocBundle #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyerbaptiste
force-pushed
the
fix_673
branch
from
7b0c567
to
a89e2f2
Compare
dunglas
reviewed
Sep 27, 2016
| @@ -171,7 +174,8 @@ private function getPropertyMetadata(ResourceMetadata $resourceMetadata, string | |||
| ($propertyMetadata->isReadable() && self::OUT_PREFIX === $io) || | |||
| ($propertyMetadata->isWritable() && self::IN_PREFIX === $io) | |||
| ) { | |||
| $data[$propertyName] = $this->parseProperty($resourceMetadata, $propertyMetadata, $io, null, $visited); | |||
| $normalizedPropertyName = null !== $this->nameConverter ? $this->nameConverter->normalize($propertyName) : $propertyName; | |||
There was a problem hiding this comment.
$this->nameConverter ? $this->nameConverter->normalize($propertyName) : $propertyName;? It doesn't hurt here because $this->nameConverter can only be null or a reference.
There was a problem hiding this comment.
Done for both @dunglas.
| @@ -378,12 +381,13 @@ private function getDefinitionSchema(string $resourceClass, ResourceMetadata $re | |||
| $options = isset($serializerContext['groups']) ? ['serializer_groups' => $serializerContext['groups']] : []; | |||
| foreach ($this->propertyNameCollectionFactory->create($resourceClass, $options) as $propertyName) { | |||
| $propertyMetadata = $this->propertyMetadataFactory->create($resourceClass, $propertyName); | |||
| $normalizedPropertyName = null !== $this->nameConverter ? $this->nameConverter->normalize($propertyName) : $propertyName; | |||
meyerbaptiste
force-pushed
the
fix_673
branch
from
a89e2f2
to
5c8df74
Compare
dunglas
approved these changes
Sep 28, 2016
teohhanhui
approved these changes
Sep 28, 2016
|
Thanks @meyerbaptiste |
This was referenced Oct 31, 2016
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
Fix api-platform#673: name converter for Swagger and NelmioApiDocBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #673 by adding the support of the name converter system to Swagger and NelmioApiDocBundle.