Various fixes after static analysis #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyerbaptiste
force-pushed
the
various_fixes_after_static_analysis
branch
from
0227fea
to
735f26a
Compare
dunglas
reviewed
Nov 2, 2016
| @@ -39,7 +39,7 @@ public function __construct(Reader $reader, PropertyMetadataFactoryInterface $de | |||
| public function create(string $resourceClass, string $property, array $options = []) : PropertyMetadata | |||
| { | |||
| $parentPropertyMetadata = null; | |||
| if (isset($this->decorated)) { | |||
| if ($this->decorated) { | |||
There was a problem hiding this comment.
Can even be compared explicitly to null.
There was a problem hiding this comment.
Shouldn't we prefer to be explicit? 😞
There was a problem hiding this comment.
Anyway we must be consistent and AFAIK we use this in other part of the code base. null === is ok too, but isset is weird.
There was a problem hiding this comment.
Yes, I'm for avoiding isset and empty as much as possible.
dunglas
approved these changes
Nov 2, 2016
meyerbaptiste
force-pushed
the
various_fixes_after_static_analysis
branch
3 times, most recently
from
a9328e4
to
d49429e
Compare
meyerbaptiste
force-pushed
the
various_fixes_after_static_analysis
branch
from
d49429e
to
83da509
Compare
|
Thanks @meyerbaptiste |
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
…after_static_analysis Various fixes after static analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: