feat: update Next.js generator style with tailwind #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Nov 7, 2022
| <a className="text-sm text-cyan-500 font-bold hover:text-cyan-700"> | ||
| {`< Back to list`} | ||
| </a> | ||
| </Link> |
alanpoulain
reviewed
Nov 7, 2022
| aria-invalid={errors.{{name}} && touched.{{name~}} ? 'true' : undefined} | ||
| onChange={handleChange} | ||
| onBlur={handleBlur} | ||
| /> | ||
| <ErrorMessage | ||
| className="invalid-feedback" | ||
| className="text-xs text-red-500 pt-1" |
There was a problem hiding this comment.
Suggested change
| className="text-xs text-red-500 pt-1" | |
| className="text-xs text-red-500 pt-1" |
alanpoulain
reviewed
Nov 7, 2022
| @@ -10,26 +10,30 @@ interface Props { | |||
| } | |||
|
|
|||
| export const List: FunctionComponent<Props> = ({ {{{lc}}}s }) => ( | |||
| <div> | |||
| <h1>{{{ucf}}} List</h1> | |||
| <div className="p-4"> | |||
There was a problem hiding this comment.
Suggested change
| <div className="p-4"> | |
| <div className="p-4"> |
|
The test failure looks related. Do you have an idea of what's going on @alanpoulain? |
|
It's probably because |
alanpoulain
force-pushed
the
feat/update-style
branch
2 times, most recently
from
3050f03
to
4d62e80
Compare
alanpoulain
force-pushed
the
feat/update-style
branch
from
4d62e80
to
7046bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
! Needs to be merged at the same time as #2320