Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swagger] Doc: Changing the name of a definition #368

Merged
merged 2 commits into from
Dec 27, 2017
Merged

[Swagger] Doc: Changing the name of a definition #368

merged 2 commits into from
Dec 27, 2017

Conversation

lyrixx
Copy link
Contributor

@lyrixx lyrixx commented Dec 26, 2017

@lyrixx lyrixx mentioned this pull request Dec 26, 2017
Merged
3 tasks
alanpoulain
alanpoulain reviewed Dec 26, 2017
View reviewed changes
core/swagger.md Outdated
### Changing the name of a definition

ApiPlatform generates a definition name based on the serializer `groups` defined
in the (`de`)`denormalization_context`. It's possible to override the name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(de)normalization_context

alanpoulain
alanpoulain reviewed Dec 26, 2017
View reviewed changes
core/swagger.md Outdated
}
```

It's also possible to re-use the `normalization_context`:
Copy link
Member

@alanpoulain alanpoulain Dec 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(de)normalization_context

@lyrixx
Copy link
Contributor Author

lyrixx commented Dec 26, 2017

Thanks @alanpoulain . I have applied your recommendations

dunglas
dunglas approved these changes Dec 26, 2017
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor style changes in your branch.

@lyrixx
Copy link
Contributor Author

lyrixx commented Dec 26, 2017

Thanks ;)

@dunglas dunglas merged commit e0e6775 into api-platform:master Dec 27, 2017
@dunglas
Copy link
Member

dunglas commented Dec 27, 2017

Thanks @lyrixx!

@lyrixx lyrixx deleted the swagger-definition-name branch December 27, 2017 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanpoulain alanpoulain alanpoulain left review comments

@dunglas dunglas dunglas approved these changes

@soyuka soyuka soyuka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lyrixx @dunglas @soyuka @alanpoulain