migrate gatsby 1.0 to 2.0 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
reviewed
Jan 17, 2019
| if (index === 0) { | ||
| next.slug = `/docs/${slugArray[2]}/${chapter.items[index + 1].id}/`; | ||
| next.title = chapter.items[index + 1].title; | ||
| } else if (slugArray[3] === item.id) { |
There was a problem hiding this comment.
Return early instead of using an else if?
alanpoulain
reviewed
Jan 17, 2019
| if (chapter.items.length - 1 !== index) { | ||
| next.slug = `/docs/${slugArray[2]}/${chapter.items[index + 1].id}/`; | ||
| next.title = chapter.items[index + 1].title; | ||
| } else { |
There was a problem hiding this comment.
Return early instead of using else?
alanpoulain
reviewed
Jan 17, 2019
| createNodeField({ | ||
| node, | ||
| name: 'redirect', | ||
| value: nodePath, | ||
| name: `slug`, |
There was a problem hiding this comment.
Suggested change
| name: `slug`, | |
| name: 'slug', |
alanpoulain
reviewed
Jan 17, 2019
| {this.props.preBodyComponents} | ||
| <div key={'body'} id="___gatsby" dangerouslySetInnerHTML={{ __html: this.props.body }} /> | ||
| <div key={`body`} id="___gatsby" dangerouslySetInnerHTML={{ __html: this.props.body }} /> |
There was a problem hiding this comment.
Suggested change
| <div key={`body`} id="___gatsby" dangerouslySetInnerHTML={{ __html: this.props.body }} /> | |
| <div key="body" id="___gatsby" dangerouslySetInnerHTML={{ __html: this.props.body }} /> |
|
There is one last issue, there is no menu animation on mobile when switching pages (no close menu animation to be precise). This is a normal as of Gatsby 2.0 : https://www.gatsbyjs.org/docs/layout-components/#how-to-prevent-layout-components-from-unmounting There is 2 solutions :
My suggestion, as this issue is minor (and don't have the time to finish now), is to fix it in a separate issue later. |
|
Thank you very much @Fabious! Good work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to Gatsby 2.0
Updated the breaking changes,
Bumped others deps too,
Refactor some code,
And fixed some wrong code (especially previous and next page on the docs)
If someone can test this feature at least locally i would be grateful, as i had to do a lot of changes ! :)
Need to be fixed