Airseeker monitoring changes to accommodate Grafana #432
Conversation
aquarat
changed the title
| @@ -159,3 +615,155 @@ export const checkAndReport = async ( | |||
| ]); | |||
| } | |||
| }; | |||
|
|
|||
| // TODO this needs to come out of the DB or some other static resource | |||
| export const DB_CHAINS = [ | |||
There was a problem hiding this comment.
Could this be replaced with the CHAINS export from the chains repo? The alias field there corresponds to the ChainInfrastructure.name field.
There was a problem hiding this comment.
Just saw this, I tried that originally but the aliases didn't match at the time. I'll try again. If they still don't match we may have to formally change them in the DBs. Warren also recently complained about the mismatch.
There was a problem hiding this comment.
The aliases don't match, I'll paste the mismatch here so we have something to refer to in future. Given the priorities we probably shouldn't fix this 🤷
Chain alias mismatch for ID 1 | Package alias: ethereum DB alias: mainnet
Chain alias mismatch for ID 11155111 | Package alias: ethereum-sepolia-testnet DB alias: sepolia
Chain alias mismatch for ID 1442 | Package alias: polygon-zkevm-goerli-testnet DB alias: polygon-zkevm-testnet
Chain alias mismatch for ID 2001 | Package alias: milkomeda-c1 DB alias: milkomeda
Chain alias mismatch for ID 200101 | Package alias: milkomeda-c1-testnet DB alias: milkomeda-testnet
Chain alias mismatch for ID 420 | Package alias: optimism-goerli-testnet DB alias: optimism-testnet
Chain alias mismatch for ID 421613 | Package alias: arbitrum-goerli-testnet DB alias: arbitrum-testnet
Chain alias mismatch for ID 5 | Package alias: ethereum-goerli-testnet DB alias: goerli
Chain alias mismatch for ID 599 | Package alias: metis-goerli-testnet DB alias: metis-testnet
| @@ -29,11 +71,14 @@ describe('alerting', () => { | |||
| // eslint-disable-next-line no-console | |||
| mockLimitedSendToOpsGenieLowLevel.mockImplementation(console.log); | |||
| setOpsGenieHandlers(mockLimitedCloseOpsGenieAlertWithAlias, mockLimitedSendToOpsGenieLowLevel); | |||
There was a problem hiding this comment.
It's also possible to mock the operations-utilities package for these handlers like here, but I don't mind the current way either 😄
In preparation for the 14th of August we required additional monitoring and a lot of changes to the existing monitoring system/apps.
Generally the approach was to try and make the logged data as easy as possible to query - so this PR tries to add that extra data.
There's a lot of mutating going on, that can't be helped.
I suggest the reviewer not worry about the migration files and instead go straight to alerting.ts and /src/ changes.
This branch is being actively used.
And apologies for the big PR.