Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changesets & CI release with provenance, replace yarn with pnpm #137

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Add changesets & CI release with provenance, replace yarn with pnpm #137

merged 2 commits into from
Mar 20, 2024

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Mar 16, 2024

Closes #122 (see issue for discussion, particularly this comment)

@dcroote dcroote self-assigned this Mar 16, 2024
Siegrift
Siegrift approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

I've read the discussion in the issue and this makes sense. I'm very happy to see this implemented.

Giving approve, but I haven't tested it myself. But even if there is something we missed, I think there is no issue to just iterate on this.

@andreogle andreogle mentioned this pull request Mar 18, 2024
Merged
@dcroote
Use main as changesets baseBranch
8e798f5 
This also updates the Actions workflow to ensure main is present for
the commit message prep step
@dcroote dcroote merged commit 758afeb into main Mar 20, 2024
3 checks passed
@dcroote dcroote deleted the dcroote/pnpm-changeset-ci branch March 20, 2024 04:54
@dcroote dcroote mentioned this pull request Mar 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreogle andreogle andreogle approved these changes

@Siegrift Siegrift Siegrift approved these changes

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to pnpm, publish via GitHub Actions with provenance
3 participants
@dcroote @andreogle @Siegrift