-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release instructions #119
Comments
This could also be fixed by migrating to pnpm and using CD via |
I think that would be a nice to have given the additional work and the amount of releases we do.
For visibility, I was wrong in the initial comment regarding rebase and merge strategy. In this followup comment you pointed out that that breaks the git tag as well. I think we can just keep pushing directly to main branch and in a special case people can open a PR and re-tag manually or ask for push to main access. |
Agreed, created #122 with the "enhancement" label
Agreed |
Also mention to run |
I think we can say this has been closed by #137 since the README is now updated with instructions using the GitHub Actions publishing with provenance flow. |
See: #118 (comment)
The instructions are almost correct, but only a few people have access to push directly to main so there should be a workaround to create a PR. Note that merging these versioning PRs should be done using Rebase and Merge strategy to prevent commit hash changing and breaking the git tag (note: it always changes when you use squash and merge).
The release instructions should also mention a new docs release (provided its a major/minor change).
The text was updated successfully, but these errors were encountered: