Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): linter looser description length #175

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

bzp2010
Copy link
Collaborator

@bzp2010 bzp2010 commented Aug 22, 2024

Description

API7 supports a longer description field than 256 bytes, while ADC sets a smaller limit for this field. This affects some use cases.
This PR relaxes the 256 length limit to 64 * 1024 = 65536 bytes.

Note that APISIX does not change its position on the 256 length limit at this time, so the Admin API still uses 256 bytes as the length limit when you use the APISIX backend. This limit may change later, but it is not a commitment.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible

@bzp2010 bzp2010 marked this pull request as ready for review August 22, 2024 03:38
schema.json Outdated Show resolved Hide resolved
@bzp2010 bzp2010 added the test/api7 Trigger the API7 test on the PR label Aug 22, 2024
@bzp2010 bzp2010 changed the title feat: looser description length feat(core): linter looser description length Aug 22, 2024
@bzp2010 bzp2010 merged commit 52087e7 into main Aug 22, 2024
7 checks passed
@bzp2010 bzp2010 deleted the bzp/feat-loose-desc-length branch August 22, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test/api7 Trigger the API7 test on the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants