feat: simple APISIX sdk #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
starsz
reviewed
Aug 22, 2023
Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
starsz
approved these changes
Aug 22, 2023
Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
starsz
reviewed
Aug 22, 2023
pkg/api/apisix/apisix.go
Outdated
| Update(ctx context.Context, ups *types.Service) (*types.Service, error) | ||
| } | ||
|
|
||
| type Upstream interface { |
There was a problem hiding this comment.
I think we can delete the Upstream interface. 🤔️
There was a problem hiding this comment.
but we should use this to call Admin API, right?
There was a problem hiding this comment.
If we really don't need the upstream resources, we can
Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
bzp2010
pushed a commit
to bzp2010/adc
that referenced
this pull request
Jul 12, 2024
bzp2010
pushed a commit
to bzp2010/adc
that referenced
this pull request
Jul 12, 2024
* feat: simple apisix sdk Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com> * rollback changes * fmt code Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com> * rollback types changes * simple rename Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com> * generic client * fix service types Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com> * remove v2 version admin API Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com> * feat: add route api Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com> * remove upstream api Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com> --------- Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
bzp2010
pushed a commit
to bzp2010/adc
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no tests yet