-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: initial run of adc configure
does not throw error
#85
Conversation
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
6870524
to
2090cd7
Compare
437706a
to
2090cd7
Compare
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
So the issue was because But this does seem to be fixed. As a workaround, we can use the This UX remains the same as before:
Without this change, if I run this, I get this error, which is why the CI was failing before:
My previous comment that it was passing when tested locally was because I already had the |
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
Description
Handling a different scenario just for the config command is different. This approach makes it better by showing warnings indicating the lack of a configuration file. Now commands that require a configuration file ask users to run
adc configure
, and if the configuration file is not present, it is shown as a warning.In the
adc configure
subcommand, when it is run initially without the configuration file being present, will show that the configuration file is not present and then proceed to create one without needing the-f
flag to overwrite the created file.Fixes #83
The other alternative was to create a new configuration file if it is not present and then write to it properly if it has just been initialized, but this is a more simple and central solution.
Checklist