Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Running adc configure for the first time fails because "config file already exists" #83

Closed
pottekkat opened this issue Oct 25, 2023 · 0 comments · Fixed by #85
Closed
Assignees
Labels
bug Something isn't working

Comments

@pottekkat
Copy link
Contributor

pottekkat commented Oct 25, 2023

Current Behavior

Running adc configure for the first time without a configuration file present will create a new file, but it will fail to write to it because it already exists. This is bad user experience:

> adc configure
Config file not found at /Users/navendu/.adc.yaml. Creating...
Please enter the APISIX server address: 
http://127.0.0.1:9180
Please enter the APISIX token: 
token
Failed to configure ADC
Error: Config File "/Users/navendu/.adc.yaml" Already Exists

Exxpected Behavior

Instead, ADC should create a new file and write to it without throwing an error.

Steps to Reproduce

Run adc configure without ~/.adc.yaml already present.

Environment

  • ADC version (run adc version): dev - 78affcd
@pottekkat pottekkat added the bug Something isn't working label Oct 25, 2023
@pottekkat pottekkat self-assigned this Oct 25, 2023
bzp2010 added a commit to bzp2010/adc that referenced this issue Jul 12, 2024
bzp2010 added a commit to bzp2010/adc that referenced this issue Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant